Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging when autodiscover configs fail #20568

Closed
ChrsMark opened this issue Aug 12, 2020 · 2 comments · Fixed by #20898
Closed

Improve logging when autodiscover configs fail #20568

ChrsMark opened this issue Aug 12, 2020 · 2 comments · Fixed by #20898
Assignees
Labels
autodiscovery bug Filebeat Filebeat Team:Platforms Label for the Integrations - Platforms team

Comments

@ChrsMark
Copy link
Member

When using autodiscover with Filebeat, errors like the following occur:

ERROR [autodiscover] autodiscover/autodiscover.go:209 Auto discover config check failed for config '{
"docker-json": {
"cri_flags": true,
"format": "auto",
"partial": true,
"stream": "all"
},
"json": {
"add_error_key": true,
"keys_under_root": true,
"overwrite_keys": true
},
"symlinks": true,
"type": "container"
}', won't start runner: each input must have at least one path defined

This kind of errors can be considered as non-fatal since they came from Pod events introduced at https://github.com/elastic/beats/pull/18979/files#diff-3a3ae93d44b91ab240d462f8f7eddc2cR365.

However we should avoid logging them since it can be confusing when looking at the logs for actual errors.

Related to #11834 (comment).

@ChrsMark ChrsMark added bug Filebeat Filebeat autodiscovery Team:Platforms Label for the Integrations - Platforms team labels Aug 12, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@jsoriano
Copy link
Member

Ideally we should detect that the configuration is using an undefined variable (it would be kubernetes.container.id) and log something specific about this, maybe only at the debug level. But not sure if the templates used support this kind of fine-grained errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autodiscovery bug Filebeat Filebeat Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants