Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] Allow to specify more than one regions in googlecloud module #17835

Closed
kaiyan-sheng opened this issue Apr 20, 2020 · 6 comments · Fixed by #32964
Closed

[Metricbeat] Allow to specify more than one regions in googlecloud module #17835

kaiyan-sheng opened this issue Apr 20, 2020 · 6 comments · Fixed by #32964
Assignees
Labels
enhancement Team:Cloud-Monitoring Label for the Cloud Monitoring team

Comments

@kaiyan-sheng
Copy link
Contributor

Right now googlecloud module only accept region parameter for one specific region, not a list of regions, which means if you want to collect metrics from more than one region, you need to repeat the config like below:

- module: googlecloud
  metricsets:
    - compute
  region: "europe-west1"
  project_id: elastic-observability
  credentials_file_path: "/Users/kaiyansheng/Downloads/elastic-observability-d17781618202.json"
  exclude_labels: false
  period: 300s
- module: googlecloud
  metricsets:
    - compute
  region: "europe-west3"
  project_id: elastic-observability
  credentials_file_path: "/Users/kaiyansheng/Downloads/elastic-observability-d17781618202.json"
  exclude_labels: false
  period: 300s
- module: googlecloud
  metricsets:
    - compute
  region: "us-central1"
  project_id: elastic-observability
  credentials_file_path: "/Users/kaiyansheng/Downloads/elastic-observability-d17781618202.json"
  exclude_labels: false
  period: 300s

It will be nice introduce a config parameter called regions to accept a list of strings:

- module: googlecloud
  metricsets:
    - compute
  regions:
    - us-central1
    - europe-west3
    - europe-west1
  project_id: elastic-observability
  credentials_file_path: "/Users/kaiyansheng/Downloads/elastic-observability-d17781618202.json"
  exclude_labels: false
  period: 300s
@kaiyan-sheng kaiyan-sheng added enhancement Metricbeat Metricbeat Team:Platforms Label for the Integrations - Platforms team labels Apr 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@exekias
Copy link
Contributor

exekias commented Apr 29, 2020

can this one be closed now?

@kaiyan-sheng
Copy link
Contributor Author

Not yet I think. Right now we accept partial region/zone as input parameter but not a list of strings.

@exekias
Copy link
Contributor

exekias commented Apr 29, 2020

sorry, my bad, I misread this!

@kaiyan-sheng kaiyan-sheng removed their assignment Oct 21, 2021
@endorama endorama added Team:Integrations Label for the Integrations team enhancement and removed Team:Platforms Label for the Integrations - Platforms team labels Jan 20, 2022
@endorama endorama added Team:Cloud-Monitoring Label for the Cloud Monitoring team and removed Team:Integrations Label for the Integrations team labels Jul 14, 2022
@endorama
Copy link
Member

@kaiyan-sheng do you think we can close this? Is 2 years old, is an enhancement but the functionality can already be used today.

@endorama
Copy link
Member

@kaiyan-sheng and I discussed this, and there is still a consolidation benefit from implementing this. AWS does it, Azure does not need it (as it leverages subscriptions) and GCP leverage globs, which are not the most expressive way. Would be nice to introduce a region list, like in AWS.

We need to check if the reason why GCP is using glob is related to internal SDK usage and the feasibility of migrating to a list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants