[generators] Generator assume global git config is setup

[andrewkroh]

The beat generator assumes that the global git config is setup when adding files to the newly created git repo. e.g it assumes that someone has done

git config --global user.email "[email protected]"
git config --global user.name "Your Name"

The variables need to be set before the generator runs git add. So the generator should check if they are set. If they are not set then it can use data provided by the user creating the beat to set them on a non-global (repo level) basis. Or it could set the appropriate environment variables to pass the name and email to Git (see https://git-scm.com/book/en/v2/Git-Internals-Environment-Variables).

The generator tests can fail because of this issue. It does run these commands, but too late.

beats/generator/common/Makefile

Lines 15 to 16 in a846029

	git config user.email "[email protected]" || exit 1 ; \
	git config user.name "beats-jenkins" || exit 1 ; \

These values need to be set after the repo is git init'ed and before git add, but it really can't as written since it's hard-coded to assume that the global git config is setup.

beats/generator/common/beatgen/beatgen.go

Lines 130 to 141 in bbf9d66

	mg.Deps(setup.GitInit)
	if cfg["type"] == "metricbeat" {
	//This is runV because it'll ask for user input, so we need stdout.
	err = sh.RunV("make", "create-metricset")
	if err != nil {
	return errors.Wrap(err, "error running create-metricset")
	}
	}
	mg.Deps(setup.Update)
	mg.Deps(setup.GitAdd)

[andrewkroh]

We're putting a work-around into CI to set the global git config. #17782

[botelastic]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[botelastic]

This issue doesn't have a Team:<team> label.