Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip “up” metrics too when not in Prometheus filters #16564

Closed
ChrsMark opened this issue Feb 25, 2020 · 0 comments · Fixed by #16568
Closed

Skip “up” metrics too when not in Prometheus filters #16564

ChrsMark opened this issue Feb 25, 2020 · 0 comments · Fixed by #16568
Assignees
@ChrsMark
Labels
enhancement Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team v7.7.0

Comments

@ChrsMark
Copy link
Member

ChrsMark commented Feb 25, 2020 •
edited
Loading

We should respect filters, implemented in #16420, when we emit up events too.

beats/metricbeat/module/prometheus/collector/collector.go

Line 93 in db85050

m.addUpEvent(eventList, 0)

Relates to #14982 also.
Will affect #16482 (comment) too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrsMark ChrsMark

Labels
enhancement Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply filters on prometheus 'up' metrics ChrsMark/beats
2 participants
@andresrc @ChrsMark