Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe all Python virtual environments in docs #14650

Closed
mtojek opened this issue Nov 20, 2019 · 5 comments
Closed

Describe all Python virtual environments in docs #14650

mtojek opened this issue Nov 20, 2019 · 5 comments
Labels

Comments

@mtojek
Copy link
Contributor

mtojek commented Nov 20, 2019

Hi,

while going through the onboarding process and basic project setup, I met few different Python virtual environments:

$ find . | egrep "activate$"
./metricbeat/build/python-env/bin/activate
./libbeat/build/python-env/bin/activate
./build/ve/darwin/bin/activate

As beats developer I wish to see unified or described purposes or details of every single one. It might be confusing for a community developer, which environment should be used for system testing, formatting docs or simply updating the project on Mac.

@kaiyan-sheng
Copy link
Contributor

How to run these tests in oss and x-pack should both be documented and how to reproduce all CI failures locally will be something great to document as well.

@philippkahr
Copy link
Contributor

I hope that this will get a lot better as soon as python3 is used? #5950 Also I think it would be worth pointing out to an ansible script, or shell script, or something like that, that exactly sets up your macOS, some linux distros and windows machine.

I love using vagrant for such things, maybe it is worth pointing out how to use vagrant to create a rebuildable OS that can be tested :)

#14148

@jsoriano
Copy link
Member

Some extra documentation has been added during the migration to Python 3, that mentions the existing virtual environments (#15833), @mtojek would this be enough?

We would be still missing the documentation Kaiyan mentions about running oss and x-pack tests, but I guess this is quite specific to the filebeat modules tests? Maybe we should create an specific issue for that.

@mtojek
Copy link
Contributor Author

mtojek commented Feb 17, 2020

Some extra documentation has been added during the migration to Python 3, that mentions the existing virtual environments (#15833), @mtojek would this be enough?

Looks good to me! Thanks!

@jsoriano
Copy link
Member

Ok, thanks! I am closing this.

@kaiyan-sheng would you mind to open another issue to better document how to test filebeat modules? or maybe we should just make it easier with a common script or mage target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants