Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test in test_base to cover the limits for default fields #14352

Closed
ph opened this issue Oct 31, 2019 · 2 comments
Closed

Add integration test in test_base to cover the limits for default fields #14352

ph opened this issue Oct 31, 2019 · 2 comments
Labels
libbeat needs_team Indicates that the issue/PR needs a Team:* label Stalled :Testing

Comments

@ph
Copy link
Contributor

ph commented Oct 31, 2019

Elasticsearch default_fields has a default limit of 1024 fields, the limit is not enforced when we created the template but it will be returned when we query Elasticsearch through Kibana.

Recently master was broken because new fields were added and we didn't detect it right away.
@andrewkroh has fixed the issues and removed unnecessary fields and added a test to make sure we don't go over.

But we are on borrowed time here until we change our template strategy because we are at 939 field now. The unit test will allow to be notified up front but we should add a new integration test to make sure that the default value of Elasticsearch is not changed to something else.

Scenario:

  • Add a test to test_based.py so all the existing beats can run it.
  • Start the beats
  • Install the template
  • Do an Elasticsearch query to see if we still have the problem.

See #14262 for a description of the behavior when it fails.

@botelastic
Copy link

botelastic bot commented Sep 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added Stalled needs_team Indicates that the issue/PR needs a Team:* label labels Sep 30, 2020
@botelastic
Copy link

botelastic bot commented Sep 30, 2020

This issue doesn't have a Team:<team> label.

@botelastic botelastic bot closed this as completed Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libbeat needs_team Indicates that the issue/PR needs a Team:* label Stalled :Testing
Projects
None yet
Development

No branches or pull requests

1 participant