From efb40e183aa494417b64d4eca992e745cbd805e8 Mon Sep 17 00:00:00 2001
From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com>
Date: Tue, 15 Feb 2022 06:59:48 -0800
Subject: [PATCH] Increase recommended k8s resource requests / limits (#29457)
 (#29977)

Changes the recommended k8s resource limits / requests to be more suitable for synthetics.

(cherry picked from commit b4624300442f95981e172105ceec4ae19426d3ac)

Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
---
 deploy/kubernetes/heartbeat-kubernetes.yaml           | 10 +++++++---
 deploy/kubernetes/heartbeat/heartbeat-deployment.yaml | 10 +++++++---
 2 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/deploy/kubernetes/heartbeat-kubernetes.yaml b/deploy/kubernetes/heartbeat-kubernetes.yaml
index ba21e40f43a4..e68076ae5eb6 100644
--- a/deploy/kubernetes/heartbeat-kubernetes.yaml
+++ b/deploy/kubernetes/heartbeat-kubernetes.yaml
@@ -100,10 +100,14 @@ spec:
           runAsUser: 0
         resources:
           limits:
-            memory: 200Mi
+            memory: 1536mi
           requests:
-            cpu: 100m
-            memory: 100Mi
+            # for synthetics, 2 full cores is a good starting point for relatively consistent perform of a single concurrent check
+            # For lightweight checks as low as 100m is fine
+            cpu: 2000m 
+            # A high value like this is encouraged for browser based monitors. 
+            # Lightweight checks use substantially less, even 128Mi is fine for those.
+            memory: 1536Mi 
         volumeMounts:
         - name: config
           mountPath: /etc/heartbeat.yml
diff --git a/deploy/kubernetes/heartbeat/heartbeat-deployment.yaml b/deploy/kubernetes/heartbeat/heartbeat-deployment.yaml
index 3f7a471b4577..63855464aff8 100644
--- a/deploy/kubernetes/heartbeat/heartbeat-deployment.yaml
+++ b/deploy/kubernetes/heartbeat/heartbeat-deployment.yaml
@@ -46,10 +46,14 @@ spec:
           runAsUser: 0
         resources:
           limits:
-            memory: 200Mi
+            memory: 1536mi
           requests:
-            cpu: 100m
-            memory: 100Mi
+            # for synthetics, 2 full cores is a good starting point for relatively consistent perform of a single concurrent check
+            # For lightweight checks as low as 100m is fine
+            cpu: 2000m 
+            # A high value like this is encouraged for browser based monitors. 
+            # Lightweight checks use substantially less, even 128Mi is fine for those.
+            memory: 1536Mi 
         volumeMounts:
         - name: config
           mountPath: /etc/heartbeat.yml