From 478229088c6bc3cfec694cfea3c44a9c539d821c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?No=C3=A9mi=20V=C3=A1nyi?= Date: Wed, 27 Apr 2022 17:25:01 +0200 Subject: [PATCH] Remove godox and add exclude rule for forbidigo (#31433) --- .golangci.yml | 4 +++- dev-tools/templates/.golangci.yml | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 4ceeb5dfaaf..02cda0353fb 100755 --- a/.golangci.yml +++ b/.golangci.yml @@ -21,6 +21,9 @@ issues: - linters: - stylecheck text: "ST1003:" + # From mage we are priting to the console to ourselves + - path: (.*magefile.go|.*dev-tools/mage/.*) + linters: forbidigo output: sort-results: true @@ -68,7 +71,6 @@ linters: - noctx # noctx finds sending http request without context.Context - unconvert # Remove unnecessary type conversions - wastedassign # wastedassign finds wasted assignment statements. - - godox # tool for detection of FIXME, TODO and other comment keywords - gomodguard # check for blocked dependencies # all available settings of specific linters diff --git a/dev-tools/templates/.golangci.yml b/dev-tools/templates/.golangci.yml index f2bae006662..ce7200589a5 100644 --- a/dev-tools/templates/.golangci.yml +++ b/dev-tools/templates/.golangci.yml @@ -18,6 +18,9 @@ issues: - text: "ST1003:" linters: - stylecheck + # From mage we are priting to the console to ourselves + - path: (.*magefile.go|.*dev-tools/mage/.*) + linters: forbidigo output: sort-results: true @@ -65,7 +68,6 @@ linters: - noctx # noctx finds sending http request without context.Context - unconvert # Remove unnecessary type conversions - wastedassign # wastedassign finds wasted assignment statements. - - godox # tool for detection of FIXME, TODO and other comment keywords - gomodguard # check for blocked dependencies # all available settings of specific linters