-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Alert annotation in Service maps #228
Comments
Pinging @elastic/observability-design (design) |
The dot on the node might be some work with normal Cytoscape.js. It might need to be drawn as part of the icon SVG (though I'm not sure if that can break out of the circle) or be a separate layer overlay on top of the graph that will need to be positioned and sized based on the pan and zoom. |
I looked at some of the demos, and there's an example where on the hover and selected state, it adds a little dot (albeit at the top of the circular node). I haven't pulled down the demo to check out how it was achieved, but I assume that's a custom SVG? https://cytoscape.org/cytoscape.js-edgehandles/demo-snap.html |
@formgeist looks like this is done with the cytoscape/cytoscape.js-edgehandles extension, which extends cytoscape itself, and those dots are for dragging a connecting line to another node. We can look at the code for that extension to see how it was done. |
@smith Thanks for investigating - right now, I'm still working on the final form of the annotation, so I'll share when I have something that we can discuss from. |
Closing in favor of #222 which also handles the design of the alert annotation |
Summary
In #170 we specified a way to indicate alerts on the service nodes. The issue had a concept of how we might annotate alerts, this issue is to complete that work separately from the original issue.
Proposed solution
The text was updated successfully, but these errors were encountered: