Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txmetrics: remove timeseries.instance field #9018

Closed
axw opened this issue Aug 31, 2022 · 2 comments · Fixed by #9565
Closed

txmetrics: remove timeseries.instance field #9018

axw opened this issue Aug 31, 2022 · 2 comments · Fixed by #9565

Comments

@axw
Copy link
Member

axw commented Aug 31, 2022

The timeseries.instance field is not used anywhere. Eventually we should move these metrics to using TSDB, which generates a timeseries ID from the dimensions.

@simitt
Copy link
Contributor

simitt commented Nov 15, 2022

Wasn't the original intention to use this e.g. for telemetry to get a better understanding of usage and potential issues with the metrics aggregation?

@axw
Copy link
Member Author

axw commented Nov 15, 2022

@simitt I don't recall tbqh. If it was, we could also do that with TSDB using the _tsid field. We could alternatively compare transaction event count to transaction metric count for a rough approximation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants