Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to warn users if we reject a fleet configuration update. #8276

Open
Mpdreamz opened this issue Jun 1, 2022 · 3 comments
Open

How to warn users if we reject a fleet configuration update. #8276

Mpdreamz opened this issue Jun 1, 2022 · 3 comments

Comments

@Mpdreamz
Copy link
Member

Mpdreamz commented Jun 1, 2022

In #8220 we are discussing ignoring bad configuration updates (specifically around invalid/empty sampling policies) which can cause APM to either go into a boot loop on cloud or effectively run in denyall mode.

Opening this issue to ensure we find a way that we don't do so silently:

  • The absolute minimum we should do is log this rejection.
  • We need a mechanism to either reject a configuration update or inform Fleet that we've only partially accepted a configuration update. (cc @elastic/fleet).
  • Explore emitting warnings from apm-server
    1. We could emit warnings in a new datastream that the @elastic/apm-ui folks could use to actively warn users of ongoing warnings.
    2. Create a dedicated warnings API in apm-server that @elastic/apm-ui could query and we can use in our diagnostics tooling.
@sorenlouv
Copy link
Member

We could emit warnings in a new datastream that the https://github.com/orgs/elastic/teams/apm-ui folks could use to actively warn users of ongoing warnings

This makes sense to me. I don't know where we'd display such information. We have discussed having a "troubleshooting" page where users can see if everything is working as expected (index template setup correctly, is number of dropped spans too high, is cardinality of span.name/transaction.name too high etc)

Create a dedicated warnings API in apm-server that https://github.com/orgs/elastic/teams/apm-ui could query and we can use in our diagnostics tooling.

Kibana does not query APM Server today. I'm not sure if this is even possible.

@Mpdreamz
Copy link
Member Author

Mpdreamz commented Jun 1, 2022

Kibana does not query APM Server today. I'm not sure if this is even possible.

It doesn't, total brainfart on my end :). Even if possible we shouldn't.

@joshdover
Copy link

I think we should be able to leverage the work in elastic/beats#21413 for this, which also includes a UI component for displaying this information in the agent details of the UI, see https://github.com/elastic/security-team/issues/3494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants