Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate static analysis of fork/exec syscalls #7109

Closed
axw opened this issue Jan 24, 2022 · 1 comment
Closed

Investigate static analysis of fork/exec syscalls #7109

axw opened this issue Jan 24, 2022 · 1 comment
Labels

Comments

@axw
Copy link
Member

axw commented Jan 24, 2022

We are looking to extend APM Server so that it can run the java-attacher when running under Fleet: #7023. On Linux, APM Server uses seccomp to filter allowed syscalls. If we continue to rely on seccomp, we will need to allow additional syscalls in order to execute java-attacher: #7017

As an alternative, we could instead verify that APM Server's dynamic call graph does not include any invocations of os/exec.Command* or syscall.*Syscall* that might run something other than java-attacher. We would also need to vet non-pure Go packages, to ensure syscalls aren't snuck in that way.

@axw
Copy link
Member Author

axw commented Jun 16, 2022

We decided that it was safe to disable seccomp. Eventually we would like to create a separate integration for agent attachment, and remove the need for fork/exec. At that time we can re-add seccomp filtering.

@axw axw closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants