Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tail Based Sampling GA #6894

Closed
13 of 21 tasks
simitt opened this issue Dec 17, 2021 · 1 comment
Closed
13 of 21 tasks

Tail Based Sampling GA #6894

simitt opened this issue Dec 17, 2021 · 1 comment

Comments

@simitt
Copy link
Contributor

simitt commented Dec 17, 2021

This is a task list of necessary work for declaring tail based sampling GA. It is a follow up of #5484, where some preliminary testing was done to identify the current status.

Required Feature Work

Stretch

Identified Bugs

Test Plan

  • Verify that sampling logic is applied correctly (use at least one service with an actual apm agent)
  • Verify the reservior sampling implementation (mix of slow and fast traces)
  • Check that logs are sufficient and helpful (on error, when reaching max number of dynamic services etc. )
  • Check that metrics are sufficient and helpful
  • Test performance, on a larger scale with multiple indices and shards
  • Follow documentation and verify that it is self-explanatory and sufficient (depends on Document tail-based sampling #4586 )
  • Test behavior on Elastic Cloud
@simitt simitt added the meta label Dec 17, 2021
@simitt simitt added this to the 8.1 milestone Dec 17, 2021
@simitt
Copy link
Contributor Author

simitt commented Feb 9, 2022

Everything required has been implemented in 8.1. Let's tick the testplan boxes when testing through the feature. Closing the issue, as the work has been done.

@simitt simitt closed this as completed Feb 9, 2022
@simitt simitt added the v8.1.0 label Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant