Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate enabling golangci-lint in CI/make check #6858

Closed
axw opened this issue Dec 8, 2021 · 2 comments
Closed

Investigate enabling golangci-lint in CI/make check #6858

axw opened this issue Dec 8, 2021 · 2 comments

Comments

@axw
Copy link
Member

axw commented Dec 8, 2021

I ran golangci-lint locally, and there were some good findings which resulted in #6857. There was also some noise, e.g. related to not checking error return on bytes.Buffer.Write calls which will only error under pathological conditions.

We should investigate using golangci-lint, perhaps with some code excluded: tests, and certain code such as described above. We should consider retiring reviewdog at the same time.

@axw
Copy link
Member Author

axw commented Jul 21, 2022

We can alternatively expand our use of staticcheck, and still get rid of golint. Maybe we also want golangci-lint, or perhaps we should just cherry-pick the specific linters/checks we want to use.

@axw
Copy link
Member Author

axw commented Oct 29, 2022

We ended up expanding our use of staticcheck: #8680

@axw axw closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants