You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I ran golangci-lint locally, and there were some good findings which resulted in #6857. There was also some noise, e.g. related to not checking error return on bytes.Buffer.Write calls which will only error under pathological conditions.
We should investigate using golangci-lint, perhaps with some code excluded: tests, and certain code such as described above. We should consider retiring reviewdog at the same time.
The text was updated successfully, but these errors were encountered:
We can alternatively expand our use of staticcheck, and still get rid of golint. Maybe we also want golangci-lint, or perhaps we should just cherry-pick the specific linters/checks we want to use.
I ran golangci-lint locally, and there were some good findings which resulted in #6857. There was also some noise, e.g. related to not checking error return on
bytes.Buffer.Write
calls which will only error under pathological conditions.We should investigate using golangci-lint, perhaps with some code excluded: tests, and certain code such as described above. We should consider retiring reviewdog at the same time.
The text was updated successfully, but these errors were encountered: