Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub: Pubsub offers no Close method for closing BulkIndexer #5493

Closed
axw opened this issue Jun 18, 2021 · 0 comments · Fixed by #5568
Closed

pubsub: Pubsub offers no Close method for closing BulkIndexer #5493

axw opened this issue Jun 18, 2021 · 0 comments · Fixed by #5568
Labels

Comments

@axw
Copy link
Member

axw commented Jun 18, 2021

The tail-based sampling pubsub implementation internally uses a go-elasticsearch BulkIndexer for indexing sampling decisions. This is never closed, as there is no method for closing the pubsub:

indexer, err := config.Client.NewBulkIndexer(elasticsearch.BulkIndexerConfig{
Index: config.DataStream.String(),
FlushInterval: config.FlushInterval,
OnError: func(ctx context.Context, err error) {
config.Logger.With(logp.Error(err)).Debug("publishing sampled trace IDs failed")
},
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant