Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM: sourcemap.error on and sourcemap.updated are set overzealously #4958

Closed
axw opened this issue Mar 16, 2021 · 0 comments · Fixed by #5631
Closed

RUM: sourcemap.error on and sourcemap.updated are set overzealously #4958

axw opened this issue Mar 16, 2021 · 0 comments · Fixed by #5631
Labels

Comments

@axw
Copy link
Member

axw commented Mar 16, 2021

We currently store sourcemap.error and sourcemap.updated on every stack frame in RUM spans and errors if no matching sourcemaps have been uploaded. This will bloat documents considerably. I would like to revisit this decision, and only set these fields under certain conditions. Specifically:

  • Only set sourcemap.error if a matching sourcemap is found and some error occurred while attempting to match and update frames. Not matching a sourcemap to a frame is not an error. For now we'll continue to set sourcemap.error at the per-frame level, but later it might make sense to set at the document level when performing sourcemapping in ingest node -- this would be more natural since we can use an on_failure handler.
  • Only set sourcemap.updated (to true) when a frame is matched and updated. Non-presence of this field means the frame has not been updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant