Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit sourcemap line length #4149

Closed
clyfish opened this issue Sep 4, 2020 · 2 comments
Closed

limit sourcemap line length #4149

clyfish opened this issue Sep 4, 2020 · 2 comments
Assignees
@stuartnelson3
Labels
enhancement low hanging fruit

Comments

@clyfish
Copy link

clyfish commented Sep 4, 2020

My coordinating node got OOM when query documents with huge lone lines in the sourcemap, so I want limit the line length of the sourcemap.

I've made a PR, but it's too hard for me to make the limit configurable.
So I closed the PR.
#4143
@clyfish clyfish mentioned this issue Sep 4, 2020
Closed
10 tasks
@stuartnelson3 stuartnelson3 self-assigned this Mar 26, 2021
@stuartnelson3 stuartnelson3 mentioned this issue Mar 29, 2021
Closed
2 tasks
@stuartnelson3
Copy link
Contributor

closing this as we haven't been able to reproduce ourselves. If you can provide a way for us to reproduce it we'll take another look.

@clyfish
Copy link
Author

clyfish commented Mar 31, 2021

After doubering the memory limit from -Xmx3g -Xms3g to -Xmx6g -Xms6g, our cluster is stable without OOM In recent months.

@axw axw removed the [zube]: Done label Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuartnelson3 stuartnelson3

Labels
enhancement low hanging fruit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support truncating sourcemap lines stuartnelson3/apm-server
4 participants
@clyfish @axw @stuartnelson3 @jalvz