Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: review docs around auth & Jaeger #3423

Closed
axw opened this issue Mar 4, 2020 · 1 comment · Fixed by #3768
Closed

docs: review docs around auth & Jaeger #3423

axw opened this issue Mar 4, 2020 · 1 comment · Fixed by #3768
Milestone

Comments

@axw
Copy link
Member

axw commented Mar 4, 2020

#3394 introduces token-based auth support for Jaeger.

Because this is not a feature natively supported by Jaeger, it is opt-in: you have to explicitly specify a process tag to use, and only once you've done that will secret-token or api-key auth be enforced for Jaeger. We should ensure the docs are clear on this.

@axw axw added this to the 7.7 milestone Mar 4, 2020
@axw axw added the docs label Mar 4, 2020
@graphaelli graphaelli removed the docs label Mar 4, 2020
@axw
Copy link
Member Author

axw commented Mar 26, 2020

While reviewing the docs I came across a false statement in our Jaeger docs:

If APM Server has apm-server.jaeger.grpc.auth_tag set, it will look for a Process tag of that name in incoming events, and use it for authorizing the Jaeger Agent against the configured secret token or API Keys. The auth tag will not be removed from the events after being verified.

Emphasis mine – that last sentence is incorrect, we do remove those tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants