Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beater/api/profile: fix pprof content-type #2954

Closed
axw opened this issue Nov 22, 2019 · 0 comments · Fixed by #3144
Closed

beater/api/profile: fix pprof content-type #2954

axw opened this issue Nov 22, 2019 · 0 comments · Fixed by #3144
Assignees
Labels
Milestone

Comments

@axw
Copy link
Member

axw commented Nov 22, 2019

Currently the content-type we look for for pprof is application/x-protobuf, but we should be more specific.

The Go agent is sending application/x-protobuf; messageType=”perftools.profiles.Profile". Note the use of rather than ", presumably copy-pasta. We'll need to fix that, and then update the server to check for the messageType suffix too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants