Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intake v2: investigate parallelizing decode and validate #1285

Closed
roncohen opened this issue Aug 15, 2018 · 4 comments
Closed

Intake v2: investigate parallelizing decode and validate #1285

roncohen opened this issue Aug 15, 2018 · 4 comments

Comments

@roncohen
Copy link
Contributor

roncohen commented Aug 15, 2018

As previously discussed, it would be interesting to investigate parallelizing the decoding and validation of documents. Transformation is already being done in parallel.

At the moment, decoding and validation is happens in parallel at the request level. E.g. incoming data from separate requests are being decoded and validated in parallel. As part of this issue, we should also seek to put a bound on that parallelization

This was referenced Aug 15, 2018
@alvarolobato alvarolobato modified the milestone: 6.6 Oct 2, 2018
@alvarolobato
Copy link

We agreed that it's a bit premature to implement this know, not even needed probably. Deferred from 6.5

@alvarolobato alvarolobato added this to the 6.5 milestone Oct 26, 2018
@simitt simitt removed this from the 6.5 milestone Feb 13, 2019
@graphaelli
Copy link
Member

graphaelli commented Apr 1, 2020

@axw do the changes you've proposed and implemented make this obsolete?

@axw
Copy link
Member

axw commented Apr 2, 2020

Nope.

#3551 will weave validation and decoding together such that parallelising them wouldn't make sense.

It might make sense to decode concurrently, e.g. have the stream processor send events to a channel to be decoded, and then have multiple goroutines processing those. This would enable parallel decoding within a single stream.

@stuartnelson3
Copy link
Contributor

Closing this for now as we aren't prioritizing time to investigate whether it's worth implementing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants