Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle spans starting after transaction is already finished. #1242

Closed
simitt opened this issue Aug 1, 2018 · 7 comments
Closed

How to handle spans starting after transaction is already finished. #1242

simitt opened this issue Aug 1, 2018 · 7 comments
Assignees
Milestone

Comments

@simitt
Copy link
Contributor

simitt commented Aug 1, 2018

Is there a way of detecting spans that were started after the trace/transaction has been finished, in the server? Is it necessary to detect?
Figure out possible implications for @elastic/apm-ui .

@simitt
Copy link
Contributor Author

simitt commented Aug 23, 2018

@elastic/apm-ui can you figure out a way to handle spans that started after a transaction already finished? I don't think there is a straight forward way to handle this in the Server.

@sorenlouv
Copy link
Member

Will the spans still be attached to the finished transaction with transaction.id? In that case we already visualize them.

It should be possible to handle. Do we still want to draw them, or should we hide them and warn the user that something in their setup is off?

@simitt
Copy link
Contributor Author

simitt commented Aug 23, 2018

As long as the @elastic/apm-agent-devs set the transaction.id we will store it.

@sorenlouv
Copy link
Member

Cool!
I'm still not sure exactly how to handle this, since I don't know if spans outside a transaction should be treated like an error in the setup, or expected behaviour.

@formgeist
Copy link
Contributor

We could possibly also go over this tomorrow (along with #1241)

@simitt
Copy link
Contributor Author

simitt commented Aug 24, 2018

The trace view will cover the duration from the first to the last span. This will be handled in the UI.

@simitt
Copy link
Contributor Author

simitt commented Aug 24, 2018

No action from the APM Server, so closing this issue.

@simitt simitt closed this as completed Aug 24, 2018
@zube zube bot added [zube]: Done and removed [zube]: Ready labels Aug 24, 2018
@simitt simitt self-assigned this Aug 24, 2018
@alvarolobato alvarolobato self-assigned this Sep 10, 2018
@alvarolobato alvarolobato added this to the 6.5 milestone Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants