Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use opentelemetry-lib for OTel enrichments #387

Open
lahsivjar opened this issue Oct 22, 2024 · 0 comments
Open

Use opentelemetry-lib for OTel enrichments #387

lahsivjar opened this issue Oct 22, 2024 · 0 comments

Comments

@lahsivjar
Copy link
Contributor

lahsivjar commented Oct 22, 2024

https://github.com/elastic/opentelemetry-lib/enrichments implements enrichment of OTel datamodel with attributes required for APM - similar to what we do in APM data. The opentelemetry-lib implementation removes dependency from some of the old semconv and Jaeger which could help us to eliminate some of the tech debt. The enrichment currently only works for traces but opentelemetry-lib could be easily extended to metrics and logs.

In addition to enrichments, we would also need translation of OTel attributes to Elastic APM attributes in opentelemetry-lib. These mappings are already captured in otel-data plugin and would need to be coded, probably in the opentelemetry-lib itself.

To bring the changes to apm-data, the code flow would need to be modified. Instead of translating the OTel data model to APM data model and applying enrichments, we would apply enrichment and then translate to APM data model.

Note that the changes done here will also impact MIS.

WIP: document exact differences between APM data handling and opentelemetry-lib handling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant