-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bundle details as a comment in PRs #667
Comments
We got this particular PR comment feature in place:
I'll raise an issue in our library to support this case among some others. |
@v1v Awesome stuff, looking forward to seeing this in action. |
What do you think with something like the below comment? |
@v1v Would be interested in the gzipped size of the individual asset and also a diff of the current vs master branch. |
@vigneshshanmugam , what do you think the below comment? In order to generate those details I created a specific implementation in our shared library, the one we use for adding more features in the Jenkinsfile. How does it work?The html bundlesize reports are transformed in json -> here What data is populated in the comment?
How to compare with the master branch or another branch?If there is a similar NOTE: red when the size increased and green when the opposite. The above image was generated with some mock data. Please let me know what you think |
@v1v Beautiful 🎉 , Thanks a ton for doing it. Just an small change, Lets add the diff based on |
It is interesting to have the bundle detail on a comment in PRs, something like the https://github.com/preactjs/compressed-size-action do, we have implemented a GitHub check that reports the bundle test result, so it is a matter of grab the details and put it in a GitHub comment that we should reutilize.
https://github.com/elastic/apm-agent-rum-js/blob/master/Jenkinsfile#L328-L346
The text was updated successfully, but these errors were encountered: