Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Intake V2 protocol #43

Closed
5 tasks done
alvarolobato opened this issue Aug 17, 2018 · 3 comments
Closed
5 tasks done

Implement Intake V2 protocol #43

alvarolobato opened this issue Aug 17, 2018 · 3 comments
Milestone

Comments

@alvarolobato
Copy link

alvarolobato commented Aug 17, 2018

Related: elastic/apm-server#1237

  • Implement ndjson.strigify
  • Add specific tests for ndjson
  • Provide required span count (Provide required span count #51)
  • Testing on apm-server v2 branch on travis
  • Review the proposal doc
@pgross41
Copy link

pgross41 commented Dec 7, 2018

Is there a way to use an array instead of the ndjson format? Chrome's network tab does not know how to parse it so it's difficult to read.

image

@hmdhk
Copy link
Contributor

hmdhk commented Dec 10, 2018

Thanks for reaching out @pgross41 ,

Using ndjson allows our apm-server to read and process the payload more efficiently, it also allows agents to reduce their memory footprint by sending data as it becomes available.

Unfortunately, one of the trade-offs we had to make was readability of the payload. You can see elastic/apm-server#1237 for more information about our intake v2.

Cheers

@pgross41
Copy link

Thanks for the info @jahtalab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants