Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CentralConfig stops fetching entirely when there's a network error #771

Closed
estolfo opened this issue Apr 21, 2020 · 2 comments · Fixed by #772
Closed

CentralConfig stops fetching entirely when there's a network error #771

estolfo opened this issue Apr 21, 2020 · 2 comments · Fixed by #772
Milestone

Comments

@estolfo
Copy link
Contributor

estolfo commented Apr 21, 2020

If a network error is encountered when fetching the remote config (i.e. a HTTP::ConnectionError), a bug in CentralConfig#schedule_next_fetch will skip scheduling the next fetch. Fetches are always scheduled by the last fetch in a chain, so as soon as a fetch has not been scheduled, the chain is broken and no future fetches will occur.

The culprit is in this line. When a network error is encountered, headers will be nil. An error would then be raised and the new @scheduled_task here will never be created.

Looking at the big picture, it might be safer and more efficient to use a TimerTask so a new ScheduledTask object is not created each time a config needs to be fetched and so that the "chain" dependency is avoided.\

Agent version is 3.6.0

@gaurav6192
Copy link

@estolfo is it resolved? In which version?

@estolfo
Copy link
Contributor Author

estolfo commented Nov 19, 2021

Hi @gaurav6192 This is resolved as of agent version 3.7.0. Are you observing an issue with central config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants