Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Node.js 15/16 #1840

Closed
shimaore opened this issue Oct 27, 2020 · 6 comments
Closed

Add support for Node.js 15/16 #1840

shimaore opened this issue Oct 27, 2020 · 6 comments
Assignees
@trentm
Labels
agent-nodejs Make available for APM Agents project planning. enhancement
Milestone
7.13

Comments

@shimaore
Copy link

Describe the bug

error [email protected]: The engine "node" is incompatible with this module. Expected version "^8.6.0 || 10 || 12 || 13 || 14". Got "15.0.1"

To Reproduce

Steps to reproduce the behavior:

  1. Install Node.js latest
  2. yarn add elastic-apm-node
  3. See error

Expected behavior

Node.js 15 should be present in package.json's engines.node.

Environment

  • OS: Linux
  • Node.js version: 15.0.1
  • APM Server version: n/a
  • Agent version: 3.7.0 / master
kevcodez added a commit to kevcodez/apm-agent-nodejs that referenced this issue Oct 28, 2020
@kevcodez
elastic#1840 feat: node 15 support
9572fb8
kevcodez added a commit to kevcodez/apm-agent-nodejs that referenced this issue Oct 28, 2020
@kevcodez
Fix: elastic#1840 feat: node 15 support
d219218
kevcodez added a commit to kevcodez/apm-agent-nodejs that referenced this issue Oct 30, 2020
@kevcodez
feat: node 15 support
ff7e1d6 
Fixes elastic#1840
@trentm trentm self-assigned this Oct 30, 2020
kevcodez added a commit to kevcodez/apm-agent-nodejs that referenced this issue Nov 3, 2020
@kevcodez
feat: node 15 support
7d2aa2b 
Fixes elastic#1840
kevcodez added a commit to kevcodez/apm-agent-nodejs that referenced this issue Nov 4, 2020
@kevcodez
feat: node 15 support
45f96cc 
Fixes elastic#1840
kevcodez added a commit to kevcodez/apm-agent-nodejs that referenced this issue Nov 4, 2020
@kevcodez
feat: node 15 support
31ac0ca 
Fixes elastic#1840
kevcodez added a commit to kevcodez/apm-agent-nodejs that referenced this issue Nov 6, 2020
@kevcodez
feat: node 15 support
0001090 
Fixes elastic#1840
kevcodez added a commit to kevcodez/apm-agent-nodejs that referenced this issue Nov 6, 2020
@kevcodez
feat: node 15 support
18d4079 
Fixes elastic#1840
@trentm trentm added the agent-nodejs Make available for APM Agents project planning. label Nov 16, 2020
kevcodez added a commit to kevcodez/apm-agent-nodejs that referenced this issue Nov 24, 2020
@kevcodez
feat: node 15 support
7c49042 
Fixes elastic#1840
kevcodez added a commit to kevcodez/apm-agent-nodejs that referenced this issue Nov 27, 2020
@kevcodez
feat: node 15 support
4ceaaf4 
Fixes elastic#1840
kevcodez added a commit to kevcodez/apm-agent-nodejs that referenced this issue Nov 27, 2020
@kevcodez
feat: node 15 support
c406360 
Fixes elastic#1840
kevcodez added a commit to kevcodez/apm-agent-nodejs that referenced this issue Nov 30, 2020
@kevcodez
feat: node 15 support
bc9462d 
Fixes elastic#1840
kevcodez added a commit to kevcodez/apm-agent-nodejs that referenced this issue Nov 30, 2020
@kevcodez
feat: node 15 support
18b150c 
Fixes elastic#1840
@akoso
Copy link

akoso commented Feb 10, 2021

Hi, any news on this?

@trentm trentm linked a pull request Feb 11, 2021 that will close this issue
Fix: #1840 feat: node 15 support #1841
Closed
@trentm
Copy link
Member

trentm commented Feb 11, 2021

It (in #1841) is still on my radar and included in our roadmap. I haven't had a chance to get back to it since the last issue I posted some details on in December.

@trentm trentm added this to the 7.13 milestone Feb 18, 2021
@trentm trentm changed the title Add support for Node.js 15 Add support for Node.js 15/16 Apr 22, 2021
@trentm trentm mentioned this issue Apr 22, 2021
Closed
@trentm
Copy link
Member

trentm commented Apr 22, 2021

The work for this now is #2055, currently our jenkins-based tests are blocked on nodejs/docker-node#1465

@trentm trentm closed this as completed in 7714701 Apr 30, 2021
@akoso
Copy link

akoso commented May 17, 2021

Can you please release to npm a new version with the node 15/16 support?

@trentm trentm mentioned this issue May 18, 2021
Merged
@trentm
Copy link
Member

trentm commented May 18, 2021

Can you please release to npm a new version with the node 15/16 support?

Thanks for the reminder! Working on it. Should have this out tomorrow.

@trentm
Copy link
Member

trentm commented May 19, 2021

[email protected] published now.

@trentm trentm mentioned this issue Jun 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trentm trentm

Labels
agent-nodejs Make available for APM Agents project planning. enhancement
Projects
None yet
Milestone
7.13
Development

Successfully merging a pull request may close this issue.

Fix: #1840 feat: node 15 support kevcodez/apm-agent-nodejs
4 participants
@trentm @shimaore @astorm @akoso