Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some async mechanisms lifecycle issues #605

Merged
merged 3 commits into from
Apr 24, 2019

Conversation

eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Apr 23, 2019

Fixes #584

@eyalkoren eyalkoren requested a review from felixbarny April 23, 2019 13:56
@eyalkoren eyalkoren self-assigned this Apr 23, 2019
@eyalkoren eyalkoren changed the title Fixing some lifecycle async mechanisms lifecycle issues Fixing some async mechanisms lifecycle issues Apr 23, 2019
@codecov-io
Copy link

codecov-io commented Apr 23, 2019

Codecov Report

Merging #605 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #605      +/-   ##
==========================================
- Coverage     63.13%    63%   -0.14%     
  Complexity       68     68              
==========================================
  Files           188    189       +1     
  Lines          7278   7319      +41     
  Branches        845    851       +6     
==========================================
+ Hits           4595   4611      +16     
- Misses         2413   2432      +19     
- Partials        270    276       +6
Impacted Files Coverage Δ Complexity Δ
...lastic/apm/agent/servlet/AsyncInstrumentation.java 59.09% <0%> (-7.58%) 0% <0%> (ø)
...apm/agent/impl/transaction/TraceContextHolder.java 50% <0%> (-6.87%) 0% <0%> (ø)
...bci/methodmatching/TraceMethodInstrumentation.java 59.57% <0%> (-5.37%) 0% <0%> (ø)
.../apm/agent/concurrent/ExecutorInstrumentation.java 41.66% <0%> (-3.62%) 0% <0%> (ø)
...ent/jaxrs/JaxRsTransactionNameInstrumentation.java 82.75% <0%> (-2.54%) 0% <0%> (ø)
...astic/apm/agent/impl/transaction/TraceContext.java 89.72% <0%> (-1.23%) 0% <0%> (ø)
...tic/apm/agent/configuration/CoreConfiguration.java 99.3% <0%> (-0.7%) 0% <0%> (ø)
...c/apm/agent/impl/async/SpanInScopeBaseWrapper.java 58.33% <0%> (ø) 0% <0%> (?)
...ic/apm/agent/servlet/ServletTransactionHelper.java 76.68% <0%> (+0.46%) 0% <0%> (ø) ⬇️
...va/co/elastic/apm/agent/impl/ElasticApmTracer.java 84.61% <0%> (+1.68%) 0% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5940bea...5506e24. Read the comment docs.

@felixbarny felixbarny merged commit 4ab2b6f into elastic:master Apr 24, 2019
@eyalkoren eyalkoren deleted the async-lifecycle-mechanism-fix branch April 24, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper life cycle management in async servlet API
3 participants