Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download agent binaries from attacher #1901

Closed
felixbarny opened this issue Jul 6, 2021 · 0 comments · Fixed by #1959
Closed

Download agent binaries from attacher #1901

felixbarny opened this issue Jul 6, 2021 · 0 comments · Fixed by #1959
Assignees
@eyalkoren
Labels
agent-java
Milestone
7.15

Comments

@felixbarny
Copy link
Member

  • Add a --download-agent-version option to the attacher CLI
  • Download the agent binaries from maven central
  • Validate the PGP signature and fail if it doesn't match the expected one
  • Store them on disk, either in the same folder or in a subfolder
  • If the binaries of the requested agent version are already in the folder, it will not re-download them
  • Use the downloaded jar when attaching to a JVM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalkoren eyalkoren

Labels
agent-java
Projects
None yet
Milestone
7.15
Development

Successfully merging a pull request may close this issue.

Downloading agent and verifying PGP signature eyalkoren/apm-agent-java
2 participants
@felixbarny @eyalkoren