Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop shading libraries #1339

Closed
Tracked by #937
felixbarny opened this issue Aug 13, 2020 · 0 comments · Fixed by #2109
Closed
Tracked by #937

Stop shading libraries #1339

felixbarny opened this issue Aug 13, 2020 · 0 comments · Fixed by #2109
Labels
agent-java blocked enhancement Enhancement of an existing feature
Milestone

Comments

@felixbarny
Copy link
Member

felixbarny commented Aug 13, 2020

Some advantages

  • Required for Add support for community supported plugins #937 so that elastic-apm-agent can be used in test module.
    This is currently not possible because Byte Buddy is shaded in elastic-apm-agent but external plugins would depend on the regular Byte Buddy as a compile dependency.
  • Simplifies Dynamic logger ecs reconfig #1261
  • Simplifies log4j2 error capturing instrumentation
  • Easier source jar generation -> simplifies debugging the agent
  • Simplifies or removes shading config

Depends on #1338
Prerequisite for #937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java blocked enhancement Enhancement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants