diff --git a/apm-agent-plugins/apm-redis-plugin/apm-jedis-4-plugin/src/test/java/co/elastic/apm/agent/jedis/Jedis4InstrumentationIT.java b/apm-agent-plugins/apm-redis-plugin/apm-jedis-4-plugin/src/test/java/co/elastic/apm/agent/jedis/Jedis4InstrumentationIT.java index 7fb48eb2b4..5cadc5d327 100644 --- a/apm-agent-plugins/apm-redis-plugin/apm-jedis-4-plugin/src/test/java/co/elastic/apm/agent/jedis/Jedis4InstrumentationIT.java +++ b/apm-agent-plugins/apm-redis-plugin/apm-jedis-4-plugin/src/test/java/co/elastic/apm/agent/jedis/Jedis4InstrumentationIT.java @@ -62,6 +62,10 @@ void testBinaryJedis() { binaryJedis.set("foo".getBytes(), "bar".getBytes()); assertThat(binaryJedis.get("foo".getBytes())).isEqualTo("bar".getBytes()); + verifyBinaryJedisSpans(); + } + + protected void verifyBinaryJedisSpans() { assertTransactionWithRedisSpans("CLIENT", "CLIENT", "SET", "GET"); } } diff --git a/apm-agent-plugins/apm-redis-plugin/apm-jedis-5-tests/pom.xml b/apm-agent-plugins/apm-redis-plugin/apm-jedis-5-tests/pom.xml index 1632f4329f..7c4c032efc 100644 --- a/apm-agent-plugins/apm-redis-plugin/apm-jedis-5-tests/pom.xml +++ b/apm-agent-plugins/apm-redis-plugin/apm-jedis-5-tests/pom.xml @@ -46,7 +46,7 @@ redis.clients jedis - 5.1.0 + 5.1.2 test diff --git a/apm-agent-plugins/apm-redis-plugin/apm-jedis-5-tests/src/test/java/jedis/Jedis5InstrumentationIT.java b/apm-agent-plugins/apm-redis-plugin/apm-jedis-5-tests/src/test/java/jedis/Jedis5InstrumentationIT.java index dc5ba27cb3..7c4c4ee045 100644 --- a/apm-agent-plugins/apm-redis-plugin/apm-jedis-5-tests/src/test/java/jedis/Jedis5InstrumentationIT.java +++ b/apm-agent-plugins/apm-redis-plugin/apm-jedis-5-tests/src/test/java/jedis/Jedis5InstrumentationIT.java @@ -24,11 +24,16 @@ public class Jedis5InstrumentationIT extends Jedis4InstrumentationIT { @Override protected void verifyShardedJedisSpan() { - assertTransactionWithRedisSpans("CLIENT", "CLIENT", "CLIENT", "CLIENT", "SET", "GET"); + assertTransactionWithRedisSpans("CLIENT", "CLIENT", "PING", "SET", "GET"); } @Override protected void verifyBasicJedisSpans() { - assertTransactionWithRedisSpans( "CLIENT", "CLIENT", "SET", "GET"); + assertTransactionWithRedisSpans("CLIENT", "CLIENT", "PING", "SET", "GET"); + } + + @Override + protected void verifyBinaryJedisSpans() { + assertTransactionWithRedisSpans("CLIENT", "CLIENT", "PING", "CLIENT", "CLIENT", "SET", "GET"); } }