Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRANSACTION_IGNORE_URLS should be dynamically configurable #814

Closed
axw opened this issue Sep 4, 2020 · 1 comment · Fixed by #872
Closed

TRANSACTION_IGNORE_URLS should be dynamically configurable #814

axw opened this issue Sep 4, 2020 · 1 comment · Fixed by #872
Labels
agent-go enhancement New feature or request
Milestone
7.12

Comments

@axw
Copy link
Member

axw commented Sep 4, 2020

TRANSACTION_IGNORE_URLS config should be dynamically configurable via central config. We currently only support configure this via an environment variable, in the apmhttp package. We'll need move the configuration over to the tracer.

See elastic/apm#333
@axw axw added the enhancement New feature or request label Sep 4, 2020
@axw axw added this to the 7.12 milestone Dec 14, 2020
@jalvz jalvz mentioned this issue Jan 21, 2021
Merged
@zube zube bot added [zube]: Done and removed [zube]: Ready labels Jan 27, 2021
@axw
Copy link
Member Author

axw commented Jan 27, 2021

We need to add go to the includeAgents list in Kibana: https://github.com/elastic/kibana/blob/053628cae862103b8c27bc60656bf45d76dc3f5d/x-pack/plugins/apm/common/agent_configuration/setting_definitions/general_settings.ts#L241-L258

Reopening this issue so we don't forget.

@axw axw reopened this Jan 27, 2021
@zube zube bot added [zube]: Inbox and removed [zube]: Done labels Jan 27, 2021
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Feb 17, 2021
@zube zube bot removed the [zube]: Done label May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-go enhancement New feature or request
Projects
None yet
Milestone
7.12
Development

Successfully merging a pull request may close this issue.

Add ignore_urls to central config jalvz/apm-agent-go
2 participants
@axw @AlexanderWert