modules silently hide panics

[slayer]

echo Middleware silently hides panic - it silently recovers it.

I'll be better to optionally recovers panics or set external handler or panics it again.
Because we need panics in logs and handle it in our way

[axw]

@slayer thanks for opening the issue. I think we should introduce an apmecho.Option similar to apmhttp.WithRecovery, and allow users to specify "nil" meaning that no recovery is performed.

I'm not sure when I'll get to this. If you would like to take on the work of implementing it, please go for it. It would be good to start with an outline of the API before going too far.

[axw]

By the way, in case it's not clear: the panics will be reported to the APM Server, and will show up in the APM UI under the "errors" tab. I do agree that there should be an option to continue propagating the panic, or to skip this panic-tracking behaviour altogether though.

[slayer]

I believe I can try implement it on next week

Yes, it shows in UI, but I spend an hour to detect why I have 500 but no errors in console logs

[axw]

Yes, it shows in UI, but I spend an hour to detect why I have 500 but no errors in console logs

Fair point!