Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use json-specs/service_resource_inference.json input in unit tests #1836

Closed
z1c0 opened this issue Sep 27, 2022 · 0 comments · Fixed by #1858
Closed

Use json-specs/service_resource_inference.json input in unit tests #1836

z1c0 opened this issue Sep 27, 2022 · 0 comments · Fixed by #1858
Assignees
@z1c0
Labels
agent-dotnet technical debt

Comments

@z1c0
Copy link
Contributor

z1c0 commented Sep 27, 2022

In #1833, json-spec input files were synced into the apm-agent-dotnet repository.

However, there are no tests yet which make use of these data.

The goal of this issue is to add new unit tests which have the JSON test definitions in service_resource_inference.json as their input.
@z1c0 z1c0 added the bug Something isn't working label Sep 27, 2022
@z1c0 z1c0 self-assigned this Sep 27, 2022
@z1c0 z1c0 added agent-dotnet and removed bug Something isn't working labels Sep 27, 2022
@z1c0 z1c0 mentioned this issue Oct 6, 2022
Merged
@z1c0 z1c0 linked a pull request Oct 6, 2022 that will close this issue
Use json-specs/service_resource_inference.json test input #1858
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@z1c0 z1c0

Labels
agent-dotnet technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use json-specs/service_resource_inference.json test input elastic/apm-agent-dotnet
2 participants
@AlexanderWert @z1c0