Upload of Certification Authority doesn't work using Ansible 2.5.1.

[iorfix]

Hi,
I'm testing new SSL ansible support.
Upload of Certification Authority doesn't work using Ansible 2.5.1 (or newer).
Relevant code is in elasticsearch-ss.yml file:

  - name: Upload SSL Certificate Authority
  copy:
    src: "{{ es_ssl_certificate_authority }}"
    dest: "{{ es_ssl_certificate_path }}/{{ es_ssl_certificate_authority | basename }}"
    owner: "{{ es_user }}"
    group: "{{ es_group }}"
    mode: 0640
  #Restart if this changes
  notify: restart elasticsearch
  when: es_ssl_certificate_authority | bool

bool filter return false in Ansible 2.5.x, since es_ssl_certificate_authority is a generic string.

 def to_bool(a):
    ''' return a bool for the arg '''
    if a is None or isinstance(a, bool):
        return a
    if isinstance(a, string_types):
        a = a.lower()
    if a in ('yes', 'on', '1', 'true', 1):
        return True
    return False

Possible solution:
Change last line to
when: (es_ssl_certificate_authority is defined) and (es_ssl_certificate_authority|length > 0)

Regards,
Dario

[jmlrt]

Hi @iorfix,
Thanks for reporting this issue, I created #647 to fix it.