Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples minor improvements #179

Merged
merged 1 commit into from
Aug 3, 2017
Merged

Examples minor improvements #179

merged 1 commit into from
Aug 3, 2017

Conversation

franciscocpg
Copy link
Member

@franciscocpg franciscocpg commented Aug 3, 2017 •
edited
Loading

What did you implement:

Related to #137

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors (not yet implemented)
  • Make sure code coverage hasn't dropped (not yet implemented)
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@franciscocpg
- Upgrading node runtime
a7045b2 
- Using slsw.lib.entries with in typescript example
@HyperBrain
Copy link
Member

Looks good

@HyperBrain HyperBrain merged commit cf51110 into serverless-heaven:master Aug 3, 2017
@franciscocpg franciscocpg mentioned this pull request Aug 3, 2017
Closed
@franciscocpg franciscocpg deleted the examples-minor-improvements branch August 3, 2017 00:12
@HyperBrain HyperBrain mentioned this pull request Aug 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyperBrain HyperBrain HyperBrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franciscocpg @HyperBrain