-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serverless-webpack is not compatible with new function level individual packaging #120
Comments
A lot of things happened within Serverless from 1.11 to 1.16. Can anyone confirm this issue and post the error again with a recent version of Serverless? Not sure if this is a feature or bug. |
I tested the But the actual result is, that there are ZIP files for each function handler, but all ZIPs are identical. In fact using the My conclusion is, that there are multiple issues with individual packaging that have to be solved. It has to work with all configurations, regardless where the flag is specified. A proper solution should configure the bundles/chunks for each individual function and set the entry points automatically. An idea of automated entry point generation can be found in #130 (deploy function support) that will need a similar packaging algorithm - somehow the packaging in there can be seen as a subset of individual packaging of multiple functions in a service. |
@HyperBrain I've made a project that reproduces this bug for me (works in https://github.com/dashmug/sls-webpack-bug-120-repro My suspicion is that the data structure in |
I will check this again after I merged #159 which fixes an artifact path issue when individual packaging is used. |
I implemented the support of the service wide The implementation uses the changed structures in 1.17 and 1.18 (the internal artifact settings changed within Serverless, which causes the problems between the two versions). |
@HyperBrain Great job on fixing that. |
I am using serverless 1.11.0 with the new function level individual packaging feature.
Here is a piece of my serverless.yml.
When I
sls deploy
, I get this error.I did a quick examination of the code and it looks like serverless-webpack doesn't examine that setting at all.
The text was updated successfully, but these errors were encountered: