Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out webpack CSS #37

Closed
elainewlin opened this issue Nov 5, 2017 · 2 comments
Closed

Figure out webpack CSS #37

elainewlin opened this issue Nov 5, 2017 · 2 comments

Comments

@elainewlin
Copy link
Owner

Currently, we import css files into js bundles. There must be some better way in webpack.

@andersk
Copy link
Collaborator

andersk commented Nov 6, 2017

This is supposed to be a thing you can do with html-webpack-plugin + file-loader + extract-loader, but it doesn’t work because extract-loader doesn’t support @import (peerigon/extract-loader#2).

You can use extract-text-webpack-plugin to generate CSS bundles (#38). This doesn’t save you from having to make JavaScript files just to import CSS. However, you can now include the CSS in the template separately from the JavaScript.

@andersk
Copy link
Collaborator

andersk commented Nov 7, 2017

This doesn’t save you from having to make JavaScript files just to import CSS.

Actually, see #40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants