Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add hpc7g.16xlarge, hpc7g.8xlarge and hpc7g.4xlarge to the list of supported instances when setting efaEnabled: true #6752

Open
mhuguesaws opened this issue Jun 30, 2023 · 5 comments
Open

[Feature] Add hpc7g.16xlarge, hpc7g.8xlarge and hpc7g.4xlarge to the list of supported instances when setting efaEnabled: true #6752

mhuguesaws opened this issue Jun 30, 2023 · 5 comments
Labels
kind/feature New feature or request priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases

Comments

@mhuguesaws
Copy link
Contributor

mhuguesaws commented Jun 30, 2023 •
edited
Loading

We just announced hpc7g instances in general availability and we need eksctl workflow when setting efaEnabled: true to support hpc7g.16xlarge, hpc7g.8xlarge and hpc7g.4xlarge in the EFA plugin.

https://github.com/weaveworks/eksctl/blob/943de8393a2a30a9ba40d7850e63f5d7c17c0e3a/pkg/addons/assets/efa-device-plugin.yaml#L36-L152

https://aws.amazon.com/about-aws/whats-new/2023/06/amazon-ec2-hpc7g-instances/
@mhuguesaws mhuguesaws added the kind/feature New feature or request label Jun 30, 2023
@bollig
Copy link

bollig commented Jun 30, 2023

related to #6743

@Himangini Himangini added the priority/important-soon Ideally to be resolved in time for the next release label Jul 3, 2023
@Himangini Himangini added priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases and removed priority/important-soon Ideally to be resolved in time for the next release labels Oct 23, 2023
@vsoch
Copy link
Contributor

vsoch commented Oct 27, 2023

Note that the pull request mentioned was marked stale and closed. I am going to look into using Terraform/Tofu instead.

@cPu1
Copy link
Contributor

cPu1 commented Oct 27, 2023

Note that the pull request mentioned was marked stale and closed. I am going to look into using Terraform/Tofu instead.

@vsoch, I have reopened the PR.

@vsoch
Copy link
Contributor

vsoch commented Oct 27, 2023

Thank you! 🙌 I'm about to go to bed, but please let me know what is needed for review. The other show stopper for us (meaning the functionality absolutely did not work given the bug) was #6870 and the daemonSet with runAsNonRoot to true. But likely we can compromise on that one and just use the helm template. But then arguably the efaEnabled should be removed here.

But overall, thank you so much for reopening this @cPu1 - I am hopeful we can get these issues resolved together, and able and willing to help however I can.

@vsoch
Copy link
Contributor

vsoch commented May 17, 2024

hey folks! My PR to add this support was again closed. Can we get this added soon, or do we need to continue to use custom bulids?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bollig @vsoch @cPu1 @Himangini @mhuguesaws