Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Story] Propagate labels and taints to ASG with propagateASGTags for managed nodegroups #5575

Closed
nikimanoledaki opened this issue Aug 4, 2022 · 0 comments · Fixed by #5678
Closed

[Story] Propagate labels and taints to ASG with propagateASGTags for managed nodegroups #5575

nikimanoledaki opened this issue Aug 4, 2022 · 0 comments · Fixed by #5678
Assignees
@TiberiuGC
Labels
area/autoscaler kind/feature New feature or request priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases

Comments

@nikimanoledaki
Copy link
Contributor

Description

This is a follow-up to #5420 and #3961.

The aim is to update propagateASGTags so that its behaviour with managed nodegroups is the same as with unmanaged nodegroups e.g. labels and taints should also be propagated as ASG tags.

Scope

  • This is for managed nodegroups to propagate labels+taints as ASG tags when propagateASGTags is set to true.

User story

As a eksctl user, so that I don't manually convert managed nodegroup's labels and taints as tags for ASG, I want them to be converted into tags and propagated automatically.

Acceptance Criteria

Technical Notes
@nikimanoledaki nikimanoledaki added the priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases label Aug 12, 2022
@TiberiuGC TiberiuGC self-assigned this Sep 5, 2022
@TiberiuGC TiberiuGC mentioned this issue Sep 6, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TiberiuGC TiberiuGC

Labels
area/autoscaler kind/feature New feature or request priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For managed nodegroups, propagate labels and taints as tags to ASG TiberiuGC/eksctl
2 participants
@nikimanoledaki @TiberiuGC