Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Token optional in NakadiClient class #23

Open
drummerwolli opened this issue Aug 31, 2023 · 0 comments
Open

Make Token optional in NakadiClient class #23

drummerwolli opened this issue Aug 31, 2023 · 0 comments

Comments

@drummerwolli
Copy link

Is your feature request related to a problem? Please describe.
At least in the Zalando context, the access tokens expire. Usually they do that after 1-3 hours. The class objects can be set up for longer periods to get re-used and use the resources of the server more optimally. But currently the NakadiClient class takes as an input the token, which makes the class only live as long as the token is valid. This reduces flexibility when setting up the NakadiClient class.

Describe the solution you'd like
A NakadiClient class which does not require necessarily a Token to be passed and an option to pass the token which each call to a function (where necessary) to the class (e.g. post_event should accept a token parameter).

Describe alternatives you've considered
Set up the NakadiClient class on each request to Nakadi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant