Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on use of idb crate. #28

Closed
devashishdxt opened this issue Aug 15, 2024 · 1 comment · Fixed by #30
Closed

Clarification on use of idb crate. #28

devashishdxt opened this issue Aug 15, 2024 · 1 comment · Fixed by #30

Comments

@devashishdxt
Copy link

Hi @fl0rek. I was looking at the usage of idb crate in blockstore and noticed that you added direct dependency of idb crate just for error conversion here. Is the something specific to this project or rexie unintentionally exposes an API that returns idb::Error?

@fl0rek
Copy link
Member

fl0rek commented Aug 22, 2024

@devashishdxt actually I remembered what it was initially.
KeyRange error types are idb errors not wrapped in rexie::Error::IdbError, so it's a bit of a leak indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants