Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geodesic distance is out-of-data with v0.4 parameterization #309

Closed
eigenvivek opened this issue Jul 15, 2024 · 0 comments · Fixed by #310
Closed

Geodesic distance is out-of-data with v0.4 parameterization #309

eigenvivek opened this issue Jul 15, 2024 · 0 comments · Fixed by #310

Comments

@eigenvivek
Copy link
Owner

The current implementation computes the distance between the last column of the transformation matrix, which represents the quantity Rt. Modify such that distance is only between translations t.

DiffDRR/diffdrr/metrics.py

Lines 146 to 153 in 528d2ea

def forward(
self,
pose_1: RigidTransform,
pose_2: RigidTransform,
) -> Float[torch.Tensor, "b"]:
t1 = pose_1.matrix[..., :3, 3]
t2 = pose_2.matrix[..., :3, 3]
return (t1 - t2).norm(dim=1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant