Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose intrinsic parameters #267

Closed
eigenvivek opened this issue Jun 11, 2024 · 0 comments · Fixed by #268
Closed

Expose intrinsic parameters #267

eigenvivek opened this issue Jun 11, 2024 · 0 comments · Fixed by #268

Comments

@eigenvivek
Copy link
Owner

Intrinsics were commented out at some point to make optimization of intrinsic parameters easier

However, some functions require the intrinsic parameters. For example,

DiffDRR/diffdrr/drr.py

Line 206 in 35d9a83

x = self.detector.sdd * torch.einsum(

Add @property decorators to access these parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose intrinsic parameters eigenvivek/DiffDRR
1 participant
@eigenvivek