From 8679fe78ea18e3388897086a8acdff95a60b9e3a Mon Sep 17 00:00:00 2001 From: Dan Field Date: Thu, 21 Apr 2022 19:23:28 -0700 Subject: [PATCH] Remove dependency on Dart, add crash handler to impellerc (#150) --- impeller/BUILD.gn | 4 ---- impeller/blobcat/BUILD.gn | 4 ---- impeller/compiler/BUILD.gn | 4 ---- impeller/compiler/impellerc_main.cc | 2 ++ 4 files changed, 2 insertions(+), 12 deletions(-) diff --git a/impeller/BUILD.gn b/impeller/BUILD.gn index 11c78699bda27..46bd75f3f4e2e 100644 --- a/impeller/BUILD.gn +++ b/impeller/BUILD.gn @@ -55,10 +55,6 @@ executable("impeller_unittests") { "blobcat:blobcat_unittests", "compiler:compiler_unittests", "geometry:geometry_unittests", - - # FML depends on the Dart VM for tracing and getting the current - # timepoint. - "//flutter/runtime:libdart", ] if (impeller_supports_rendering) { diff --git a/impeller/blobcat/BUILD.gn b/impeller/blobcat/BUILD.gn index 4899e5f9708d2..b38d29bdcfe9d 100644 --- a/impeller/blobcat/BUILD.gn +++ b/impeller/blobcat/BUILD.gn @@ -29,10 +29,6 @@ impeller_component("blobcat") { ":blobcat_lib", "../base", "//flutter/fml", - - # FML depends on the Dart VM for tracing and getting the current - # timepoint. - "//flutter/runtime:libdart", ] } diff --git a/impeller/compiler/BUILD.gn b/impeller/compiler/BUILD.gn index 249944ca64abc..501a8bb5efd27 100644 --- a/impeller/compiler/BUILD.gn +++ b/impeller/compiler/BUILD.gn @@ -44,10 +44,6 @@ impeller_component("impellerc") { deps = [ ":compiler_lib", - - # FML depends on the Dart VM for tracing and getting the current - # timepoint. - "//flutter/runtime:libdart", ] } diff --git a/impeller/compiler/impellerc_main.cc b/impeller/compiler/impellerc_main.cc index 2ce1b4ac6b61e..67d8616f896e0 100644 --- a/impeller/compiler/impellerc_main.cc +++ b/impeller/compiler/impellerc_main.cc @@ -4,6 +4,7 @@ #include +#include "flutter/fml/backtrace.h" #include "flutter/fml/command_line.h" #include "flutter/fml/file.h" #include "flutter/fml/macros.h" @@ -18,6 +19,7 @@ namespace impeller { namespace compiler { bool Main(const fml::CommandLine& command_line) { + fml::InstallCrashHandler(); if (command_line.HasOption("help")) { Switches::PrintHelp(std::cout); return true;