Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch mode gives SIGABRT error once built #1171

Closed
FilipPyrek opened this issue Jul 28, 2024 · 3 comments · May be fixed by nerdy-tech-com-gitub/chroma#10
Closed

Watch mode gives SIGABRT error once built #1171

FilipPyrek opened this issue Jul 28, 2024 · 3 comments · May be fixed by nerdy-tech-com-gitub/chroma#10
Labels

Comments

@FilipPyrek
Copy link

FilipPyrek commented Jul 28, 2024

Cause

After this change was introduced #1142 by @SunsetTechuila via release v8.2.1 we started to get SIGABRT error in watch mode.

Error

ESM dist/files/index.js                                    3.85 KB
ESM ⚡️ Build success in 87ms
CLI Watching for changes in "."
CLI Ignoring changes in "**/{.git,node_modules}/**" | "dist"
DTS Build start
DTS ⚡️ Build success in 13504ms
ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL  Command was killed with SIGABRT (Aborted): tsup-node --dts --no-splitting --tsconfig ./tsconfig.dev.json --format esm --watch
ELIFECYCLE  Command failed with exit code 1.

image

Temporary fix

Reverting back to 8.2.0 fixed it for me.

Debugging

When I removed worker.terminate() from src/index.ts it worked without throwing any error. ✅

worker.on('message', (data) => {
  if (data === 'error') {
-   worker.terminate()
    reject(new Error('error occured in dts build'))
  } else if (data === 'success') {
-   worker.terminate()
    resolve()
  } else {
    const { type, text } = data

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@SunsetTechuila
Copy link
Contributor

SunsetTechuila commented Jul 28, 2024

hello, sorry for that
i can't reproduce your issue. could you provide more info, like your tsconfig, os/node/pnpm version? or even better, could try the suggested solution from #1140?

@FilipPyrek
Copy link
Author

Thanks, here are the versions:

node: 20.11.0
pnpm: 9.1.0

I'm not sure where exactly is the problem. 🤔 🤷‍♂️
All I can say is that it was happening to multiple colleagues of mine.

@egoist egoist closed this as completed in 49c11c3 Aug 2, 2024
Copy link
Contributor

github-actions bot commented Aug 2, 2024

🎉 This issue has been resolved in version 8.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants