`watch` Command - watch files/dirs and rerun task on change #33

flxwu · 2018-06-05T17:38:47Z

Resolves #9

Example

Run task `lint` before this and watch `*.js`

will rerun lint everytime a JavaScript file is changed

…ching

zephraph · 2018-06-06T02:23:18Z

lib/index.js

-function checkTypes(task, types) {
-  return types.some(type => type === task.type)
-}
-


Why pull this out? I don't disagree with the change, just trying to understand.

Because it's needed in the MaidRunner 😄

tunnckoCore · 2018-06-06T18:48:02Z

lib/FileWatcher.js

-      .on('change', path => runner.runFile(this.getTaskName(path)))
-      .on('unlink', path => runner.runFile(this.getTaskName(path)))
+      .on('add', path =>
+        this.getTaskNames(path).forEach(taskName => runner.runFile(taskName))


synchronous forEach which executes async runFile? Ouch.

…ending on the task name

lib/parseMarkdown.js

flxwu · 2018-06-06T21:34:15Z

@olstenlarck just made the task executions asynchronous :)

zephraph · 2018-06-06T22:23:18Z

lib/parseMarkdown.js

+    )
+  ) + LAZY,
+  capture(and(space, 'and', space, 'watch', space, capture(extra(ANY)))) + LAZY,
+  wildcard(SPACE)


So when I implemented #23, I shortened this to only key off of Runs? tasks?. It loosens the general word order. You know need to include this for example. This reintroduces those changes plus some. Let's talk through ways of expressing watch without requiring such a rigid expression.

I can take out the this to be optional

Actually, this now enables several expressions:

Run task `lint` in parallel and watch ...

Run tasks `lint`, `build` and `clean` in parallel and watch ...

Run task `lint` after this / before this in parallel and watch ...

Run task `lint` and watch ...

And I really don't think the user feels more convinient writing

Run task `lint` after in parallel

instead of

Run task `lint` after this in parallel

as latter would be a proper sentence

lib/FileWatcher.js

zephraph · 2018-06-06T22:36:52Z

This isn't immediately clear to me...

Run task `lint` before this and watch `*.js`

What's the actual intent? Watch all js files for changes and when a change happens rerun lint? Does the actual task that the watch command in rerun?

What about complex expressions? Let's say I'm running a command dev. I want it to clean and then lint and build on every js change.

Runs task `clean`
Runs tasks `lint` and `build` when `*.js` files change

Maybe static runs and watch runs shouldn't be in the same sentence. It might be shorter that way, but it's not necessarily any more clear.

Thoughts @flxwu?

tunnckoCore · 2018-06-06T22:40:29Z

lib/FileWatcher.js

@@ -1,6 +1,11 @@
 const chokidar = require('chokidar')
 const logger = require('./logger')

+Array.prototype.asyncForEach = async function(callback) { // eslint-disable-line


Ouch, why? I just really can't believe what i'm looking 🤣

p-map-series or p-map is probably better fit.

Hmm... I missed that. Yeah, probably don't want to modify the prototype.

okay thanks @olstenlarck

flxwu · 2018-06-07T07:22:28Z

@zephraph

Run task `lint` before this and watch `*.js`

will run lint on every js file change

Your dev would have to look like that if you want it to do all three tasks clean,lint,build on a JS file change:

Runs tasks `clean`, `lint` and `build` and watch `*.js`

If you want to run clean once, you'd have to do it like that:

Runs task `clean`
Runs tasks `lint` and `build` and watch `*.js`

However, this is not implemented yet I think, or is it? I mean multiline tasks @zephraph @olstenlarck @egoist

tunnckoCore · 2018-06-07T12:18:38Z

@flxwu seems like it works, but not correctly.

### baw

Some sample task

Run task `foo` after this
Run task `bar` after this

```bash
echo "baaaawww"
```

### foo

Somedadadadad

```bash
echo "foo"
```

### bar

Sosasasas

```bash
echo "bar"
```

outputs

❯ yarn maid baw
yarn run v1.7.0
$ node bin/cli baw
[15:16:26] Starting 'baw'...
baaaawww
[15:16:26] Finished 'baw' after 15 ms...
[15:16:26] Starting 'foo1'...
foo
[15:16:26] Finished 'foo1' after 6 ms...
[15:16:26] Starting 'bar'...
bar
[15:16:26] Finished 'bar' after 6 ms...
Done in 0.47s.

btw, does this PR support another than this? I mean

Run task `foo` after `bar`

kinda thing?

flxwu · 2018-06-07T13:10:15Z

Run tasks `foo` after `bar`

Does it work in the current version? @olstenlarck

tunnckoCore · 2018-06-07T13:40:31Z

dont know, didnt thought to try.

egoist · 2018-06-07T14:27:26Z

Definitely should not support Run task `foo` after `bar` 😂

tunnckoCore · 2018-06-07T17:46:07Z

huh, why not?

zephraph · 2018-06-07T17:55:31Z

It's not really needed, is it? #23 loosens the restrictions so Run tasks `foo` after `bar` works, but it might not do what you think. Run tasks triggers the language expression. foo and bar are collected as tasks to run. after means that the commands should run after the current command.

flxwu · 2018-06-15T15:16:45Z

@egoist Are you going to merge this or what is still missing? 😄

jakepearson · 2018-10-09T11:52:36Z

@flxwu I have access to start merging, would you fix the conflicts and I will merge today. Thanks.

flxwu · 2018-10-21T19:58:35Z

Done! @jakepearson

Felix Wu added 12 commits June 5, 2018 14:42

add node-chokidar for watching files

74740bc

add FileWatcher class for watch command

57c6491

adapt command parsing to new command regex

ee1bdeb

outsource MaidRunner

47db52e

on file change, get the task that is watching that file and run it

e8aae67

pass the tasks name to watch()

40c09de

use the regexGroups array for better readability

3707763

merge master

845c907

only init watcher on first file, only log&add file if not already wat…

b923dea

…ching

turn FileWatcher into Singleton

68db54a

adapt unwatch and close to singleton

d7ed3c6

regenerate snapshots

e943ca6

zephraph reviewed Jun 6, 2018

View reviewed changes

Felix Wu added 3 commits June 6, 2018 11:44

update to loosened restrictions

9994219

run all tasks subsequently in case a task array gets passed

6f4b301

auto-fix commands without 'when' by defaulting to 'before this'

b784d7c

tunnckoCore reviewed Jun 6, 2018

View reviewed changes

Felix Wu added 2 commits June 6, 2018 23:20

include edge cases in fixCommand, don't append anything if it's just …

710d83f

…ending on the task name

trying to fix the tests

a5d3f74

zephraph reviewed Jun 6, 2018

View reviewed changes

lib/parseMarkdown.js Outdated Show resolved Hide resolved

make tasks execution on watch action asynchronous

7858fb2

use custom asyncForEach

0604f20

zephraph reviewed Jun 6, 2018

View reviewed changes

lib/FileWatcher.js Show resolved Hide resolved

tunnckoCore reviewed Jun 6, 2018

View reviewed changes

flxwu mentioned this pull request Aug 13, 2018

Watch files #9

Open

Felix Wu added 2 commits October 21, 2018 21:49

merge

be6af5d

CRC

af47299

flxwu closed this Jul 31, 2021

flxwu deleted the feature/watch-files branch July 31, 2021 22:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`watch` Command - watch files/dirs and rerun task on change #33

`watch` Command - watch files/dirs and rerun task on change #33

flxwu commented Jun 5, 2018 •

edited

Loading

zephraph Jun 6, 2018 •

edited

Loading

flxwu Jun 6, 2018

tunnckoCore Jun 6, 2018

flxwu commented Jun 6, 2018

zephraph Jun 6, 2018

flxwu Jun 7, 2018

flxwu Jun 7, 2018

flxwu Jun 7, 2018

zephraph commented Jun 6, 2018

tunnckoCore Jun 6, 2018 •

edited

Loading

zephraph Jun 6, 2018

flxwu Jun 7, 2018

flxwu commented Jun 7, 2018 •

edited

Loading

tunnckoCore commented Jun 7, 2018 •

edited

Loading

flxwu commented Jun 7, 2018

tunnckoCore commented Jun 7, 2018

egoist commented Jun 7, 2018

tunnckoCore commented Jun 7, 2018

zephraph commented Jun 7, 2018

flxwu commented Jun 15, 2018

jakepearson commented Oct 9, 2018

flxwu commented Oct 21, 2018

watch Command - watch files/dirs and rerun task on change #33

watch Command - watch files/dirs and rerun task on change #33

Conversation

flxwu commented Jun 5, 2018 • edited Loading

zephraph Jun 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flxwu commented Jun 6, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zephraph commented Jun 6, 2018

tunnckoCore Jun 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flxwu commented Jun 7, 2018 • edited Loading

tunnckoCore commented Jun 7, 2018 • edited Loading

flxwu commented Jun 7, 2018

tunnckoCore commented Jun 7, 2018

egoist commented Jun 7, 2018

tunnckoCore commented Jun 7, 2018

zephraph commented Jun 7, 2018

flxwu commented Jun 15, 2018

jakepearson commented Oct 9, 2018

flxwu commented Oct 21, 2018

`watch` Command - watch files/dirs and rerun task on change #33

`watch` Command - watch files/dirs and rerun task on change #33

flxwu commented Jun 5, 2018 •

edited

Loading

zephraph Jun 6, 2018 •

edited

Loading

tunnckoCore Jun 6, 2018 •

edited

Loading

flxwu commented Jun 7, 2018 •

edited

Loading

tunnckoCore commented Jun 7, 2018 •

edited

Loading