-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename beforeAll/afterAll
to pre/post
?
#7
Comments
Interesting suggestion. While that does a good job of aligning with the naming convention, I feel like it could be confusing about the context of when it runs. Is it pre each task? As in, does in run before anything else runs. Or is it pre all tasks? I know in this context it applies to the latter, but a task named pre isn't very descriptive to the on-looker. I wonder if instead we could make a plain english semantic to marry with the i.e.
|
@zephraph I'm not sure I totally understand. I think "before anything else runs" and "pre all tasks" are kind of synonymous. I'd personally avoid any of the plain english stuff, since I think it makes the API really hard to remember. |
I disagree @ianstormtaylor. It should be plain English. That's what makes this so interesting. However it should still be a standard API.
In our case, these are:
Or |
Upon thinking about the above more, it wont work. How do I run multiple "before all tasks" before themselves? Having a single command called "beforeAll", "afterAll" makes sense, because there should only be one of each. |
You could still do a label, just error out if there's more than one. I think the current beforeAll, afterAll semantics are fine too though. |
Hey, thanks for the interesting tool!
I was just gonna make a suggestion. Right now you can have things like
postbuild
andprebuild
which run automatically. But the automatic before/after everything is confusingly namedafterAll
andbeforeAll
, which isn't consistent.It might be nice to allow
pre
andpost
tasks that run before/after everything instead, to stay consistent. It feels natural thatpre
withoutpre{task}
would count for everything.The text was updated successfully, but these errors were encountered: