Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure TestContext registeres all dependencies as services, provide them options #114

Closed
egil opened this issue May 2, 2020 · 1 comment
Labels
enhancement New feature or request input needed When an issue requires input or suggestions

Comments

@egil
Copy link
Member

egil commented May 2, 2020

Things like the markup parser and markup comparer can be passed options and configuration or replaced entirely to change their behavior. If they are registered by default in the test service provider, they can be replaced or accessed by the test.

In addition to this, we should consider making it possible to pass options to the drivers services though the aspnetcore options pattern

@egil egil added enhancement New feature or request input needed When an issue requires input or suggestions labels May 2, 2020
@egil
Copy link
Member Author

egil commented May 4, 2020

Created a simple extension method used in all the places web test contexts are created, that registers the HtmlParser, HtmlComparer, and the ITestRenderer.

egil added a commit that referenced this issue May 4, 2020
… HtmlParser, HtmlComparer to the services collection by default.

Closes issue #114
@egil egil closed this as completed May 4, 2020
@egil egil added this to the beta-7 milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request input needed When an issue requires input or suggestions
Projects
None yet
Development

No branches or pull requests

1 participant