Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/231 focus async #260

Merged
merged 5 commits into from
Nov 21, 2020
Merged

Feature/231 focus async #260

merged 5 commits into from
Nov 21, 2020

Conversation

egil
Copy link
Member

@egil egil commented Nov 20, 2020

Closes #231

PR meta checklist

  • Pull request is targeting at DEV branch.
  • Pull request is linked to all related issues, if any.
  • I have read the CONTRIBUTING.md document.

Content checklist

  • My code follows the code style of this project and AspNetCore coding guidelines.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have updated the appropriate sub section in the CHANGELOG.md.
  • I have added, updated or removed tests to according to my changes.
    • All tests passed.

@egil egil linked an issue Nov 20, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #260 (0292a9a) into dev (d4ede22) will increase coverage by 0.13%.
The diff coverage is 91.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #260      +/-   ##
==========================================
+ Coverage   80.39%   80.53%   +0.13%     
==========================================
  Files         110      116       +6     
  Lines        3458     3508      +50     
  Branches      443      444       +1     
==========================================
+ Hits         2780     2825      +45     
- Misses        543      547       +4     
- Partials      135      136       +1     
Impacted Files Coverage Δ
src/bunit.core/Rendering/RootRenderTree.cs 100.00% <ø> (ø)
...bunit.core/Rendering/RootRenderTreeRegistration.cs 100.00% <ø> (ø)
...c/bunit.web/JSInterop/JSRuntimeAssertExtensions.cs 92.10% <ø> (+5.26%) ⬆️
...ubles/Authorization/FakeAuthorizationExtensions.cs 100.00% <ø> (ø)
src/bunit.core/Rendering/TestRenderer.cs 94.02% <28.57%> (-3.63%) ⬇️
...it.web/JSInterop/JSRuntimeInvocationHandlerBase.cs 84.84% <84.84%> (ø)
src/bunit.core/RazorTesting/FragmentContainer.cs 100.00% <100.00%> (ø)
src/bunit.core/TestContextBase.cs 100.00% <100.00%> (ø)
...it.web/Extensions/TestServiceProviderExtensions.cs 100.00% <100.00%> (ø)
src/bunit.web/JSInterop/BunitJSInterop.cs 100.00% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4ede22...0292a9a. Read the comment docs.

@egil egil force-pushed the feature/231-FocusAsync branch from b2231da to b6790bc Compare November 21, 2020 10:13
@egil egil merged commit a3fc598 into dev Nov 21, 2020
@egil egil deleted the feature/231-FocusAsync branch November 21, 2020 10:28
@egil egil mentioned this pull request Dec 8, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ElementReference.FocusAsync from .NET 5
1 participant