-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InvokeAsync overload #177
Conversation
…ase, changed IRenderedFragment to enable converting method to extension methods
Hi @JeroenBos Thanks for this. Here is my initial comments:
|
src/bunit.core.tests/Extensions/RenderedComponentInvokeAsyncExtensionsTest.cs
Show resolved
Hide resolved
Yes I question the need for them as well. They were more the result of trying to make a good PR.
I'm not clear on the design details for cut.SetParametersAndRender();
await cut.WaitForState(); to await cut.SetParametersAndRenderAsync(); which is even simpler for folks. |
src/bunit.core/Extensions/RenderedComponentInvokeAsyncExtension.cs
Outdated
Show resolved
Hide resolved
…n.cs Co-authored-by: Jeroen Bos <[email protected]>
In most cases, calling The WaitFor* methods are only needed when something triggered from the test code causes the renderer to perform multiple renders asynchronously. See more here: https://bunit.egilhansen.com/docs/verification/async-assertion.html |
I just pushed an update to the docs. I think this is done. You? |
It's merged. Thanks so much @JeroenBos for taking the lead on this and helping out. |
Fixes #166.
Some remarks:
However, I did revert those breaking changes, so consider a squash merge.
PR meta checklist
DEV
branch.Content checklist